[Notes] Port to QQC2 and use GridView KCM components for the color chooser
ClosedPublic

Authored by ngraham on May 15 2019, 3:56 AM.

Details

Summary

Additional changes:

  • Use standard import names

Thanks to @GB_2 for providing the skeleton of this patch

Test Plan

Everything works and color value is saved and loaded properly

Diff Detail

Repository
R114 Plasma Addons
Branch
modernize-notes-settings-window (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 11845
Build 11863: arc lint + arc unit
ngraham created this revision.May 15 2019, 3:56 AM
Restricted Application added a project: Plasma. · View Herald TranscriptMay 15 2019, 3:56 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
ngraham requested review of this revision.May 15 2019, 3:56 AM
ngraham updated this revision to Diff 58112.May 15 2019, 3:59 AM

Revert one unnecessary ID change

ngraham updated this revision to Diff 58113.May 15 2019, 4:03 AM

Revert one last unnecessary change

ndavis accepted this revision.May 15 2019, 4:26 AM
ndavis added a subscriber: ndavis.

LGTM, visually.

This revision is now accepted and ready to land.May 15 2019, 4:26 AM
ngraham updated this revision to Diff 58121.May 15 2019, 12:45 PM

Bring back old text switch method (it was less buggy)

ngraham edited the summary of this revision. (Show Details)May 15 2019, 12:46 PM
mart accepted this revision.May 15 2019, 12:46 PM
mart added a subscriber: mart.

I'm not 100% sure about using kcm components outside actual kcms, but i guess to fix that properly it would need those components in a more abstract manner somewhere else like in kirigami and then the kcm import only specializing it.

So for now don't worry about that and go for it.

ngraham edited the test plan for this revision. (Show Details)May 15 2019, 12:47 PM
This revision was automatically updated to reflect the committed changes.
davidedmundson added inline comments.
applets/notes/package/contents/ui/configAppearance.qml
61

this looks like it's a bad merge

ngraham marked an inline comment as done.May 15 2019, 1:19 PM
ngraham added inline comments.
applets/notes/package/contents/ui/configAppearance.qml
61

Fixed in 61ab2de7bf19a496e11085245b2fa65a48bd6408, sorry about that.