Differential D21220

[Touchpad KCM] Fix libinput-less build and warnings
ClosedPublic
Actions

Authored by romangg on May 14 2019, 8:36 PM.

Details

Reviewers
davidedmundson
Group Reviewers
Plasma
Commits
R119:8b1c894effa0: [Touchpad KCM] Fix libinput-less build and warnings
Summary

If the X.Org libinput dev packages are not found, do not
build the X11 libinput backend. This way the build succeeds.

Fix also some minor warnings.

Diff Detail

Repository
R119 Plasma Desktop
Branch
touchpadLibinputFixes
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 11842
Build 11860: arc lint + arc unit
romangg created this revision.May 14 2019, 8:36 PM
Restricted Application added a project: Plasma. · View Herald TranscriptMay 14 2019, 8:36 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
romangg requested review of this revision.May 14 2019, 8:36 PM
romangg updated this revision to Diff 58100.May 14 2019, 8:55 PM

Also include libinput header only when compiling with X.Org libinput.

davidedmundson accepted this revision.May 14 2019, 10:30 PM
This revision is now accepted and ready to land.May 14 2019, 10:30 PM
Closed by commit R119:8b1c894effa0: [Touchpad KCM] Fix libinput-less build and warnings (authored by romangg). · Explain WhyMay 15 2019, 12:01 AM
This revision was automatically updated to reflect the committed changes.
zzag added a subscriber: zzag.May 15 2019, 7:23 AM
zzag added inline comments.
kcms/touchpad/src/backends/libinputcommon.h
28

Just a note for the future: you don't have to define this function. It's enough to do

template <typename T>
T valueLoaderPart(QVariant const &reply);

Revision Contents
Changeset List

Diff 58100

View Options

CMakeLists.txt

Loading...
View Options

config-X11.h.cmake

Loading...
View Options

kcms/touchpad/src/backends/libinputcommon.h

Loading...
View Options

kcms/touchpad/src/backends/x11.cmake

Loading...
View Options

kcms/touchpad/src/backends/x11/libinputtouchpad.cpp

Loading...
View Options

kcms/touchpad/src/backends/x11/xlibbackend.cpp

Loading...