[Holidays plugin] Port partially to QQC2 and modernize UI
ClosedPublic

Authored by ngraham on May 13 2019, 5:18 PM.

Details

Summary
  • Port mostly to QQC2 (Don't touch the TableView since there's no QQC2 version yet)
  • Use standard import names
  • Adjust search field placeholder text to follow the common style
Test Plan

Diff Detail

Repository
R120 Plasma Workspace
Branch
modernize-holidays-plugin (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 11800
Build 11818: arc lint + arc unit
ngraham created this revision.May 13 2019, 5:18 PM
Restricted Application added a project: Plasma. · View Herald TranscriptMay 13 2019, 5:18 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
ngraham requested review of this revision.May 13 2019, 5:18 PM
ngraham edited the summary of this revision. (Show Details)May 13 2019, 5:21 PM
ngraham retitled this revision from [Holidays plugin] Port partially to QQC2 to [Holidays plugin] Port partially to QQC2 and modernize UI.
ndavis accepted this revision.May 15 2019, 2:17 AM
ndavis added a subscriber: ndavis.

No visual changes, so LGTM

This revision is now accepted and ready to land.May 15 2019, 2:17 AM
This revision was automatically updated to reflect the committed changes.