Differential D21193

[Astronomical Calendar Plugin] Port to QQC2+Kirigami Formlayout
ClosedPublic
Actions

Authored by ngraham on May 13 2019, 5:10 PM.

Details

Reviewers
ndavis
Group Reviewers
VDG
Plasma
Maniphest Tasks
T10586: Modernize widget configuration settings
Commits
R114:4b1607879f23: [Astronomical Calendar Plugin] Port to QQC2+Kirigami Formlayout
Summary
  • Port to QQC2+Kirigami FormLayout style
  • Use standard import names
  • Adjust strings to fit in the FormLayout style
Test Plan

Diff Detail

Repository
R114 Plasma Addons
Branch
modernize-astronomical-calendar-plugin (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 11799
Build 11817: arc lint + arc unit
ngraham created this revision.May 13 2019, 5:10 PM
Restricted Application added a project: Plasma. · View Herald TranscriptMay 13 2019, 5:10 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
ngraham requested review of this revision.May 13 2019, 5:10 PM
ndavis accepted this revision.May 15 2019, 2:09 AM
ndavis added a subscriber: ndavis.

LGTM, visually

This revision is now accepted and ready to land.May 15 2019, 2:09 AM
Closed by commit R114:4b1607879f23: [Astronomical Calendar Plugin] Port to QQC2+Kirigami Formlayout (authored by ngraham). · Explain WhyMay 15 2019, 2:34 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 58021

View Options

plasmacalendarplugins/astronomical/config/qml/AstronomicalEventsConfig.qml

Loading...