[Notifications] Ensure "Open" and "More Options" button have the same height
ClosedPublic

Authored by broulik on May 13 2019, 7:20 AM.

Diff Detail

Repository
R120 Plasma Workspace
Lint
Lint Skipped
Unit
Unit Tests Skipped
broulik created this revision.May 13 2019, 7:20 AM
Restricted Application added a project: Plasma. · View Herald TranscriptMay 13 2019, 7:20 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
broulik requested review of this revision.May 13 2019, 7:20 AM
broulik updated this revision to Diff 57982.
broulik edited the summary of this revision. (Show Details)
broulik added a reviewer: Plasma.
davidedmundson requested changes to this revision.May 13 2019, 9:09 AM
davidedmundson added a subscriber: davidedmundson.

See my last comment on the bug. Sorry.

If you can explain why it's needed I'll happily click ship it.

This revision now requires changes to proceed.May 13 2019, 9:09 AM

This fixes the issue for me, but it feels like we should make the fix in plasma-framework to the button itself so everyone gets the benefit of the fix automatically, no?

So, what shall we do?

Based on @davidedmundson's comments in the bug report I think we can do this?

davidedmundson accepted this revision.May 24 2019, 1:40 PM
This revision is now accepted and ready to land.May 24 2019, 1:40 PM
This revision was automatically updated to reflect the committed changes.