FrameSvgItem: emit maskChanged always from doUpdate()
ClosedPublic

Authored by kossebau on May 13 2019, 6:25 AM.

Details

Summary

In that method we can assue a high chance that the mask is also affected.
Instead of adding complicated additional code to track if the mask
really changed, we rely on the cached value from FrameSvg.
This method is not too often called in a Plasma session, so that
further optimization work to avoid unneccesary emits seems not yet
worth it.

Diff Detail

Repository
R242 Plasma Framework (Library)
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
kossebau created this revision.May 13 2019, 6:25 AM
Restricted Application added a project: Frameworks. · View Herald TranscriptMay 13 2019, 6:25 AM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
kossebau requested review of this revision.May 13 2019, 6:25 AM
davidedmundson accepted this revision.May 13 2019, 4:41 PM
This revision is now accepted and ready to land.May 13 2019, 4:41 PM
This revision was automatically updated to reflect the committed changes.