Differential D21161

Fix incomplete EXIF data for RAW files
ClosedPublic
Actions

Authored by tommo on May 12 2019, 5:15 PM.

Details

Reviewers
ngraham
Group Reviewers
Gwenview
Commits
R260:a985ad14dc07: Fix incomplete EXIF data for RAW files
Summary

In case of RAW files exiv2 retrieved the EXIF data from the JPEG preview
image previewData. This however contains incomplete EXIF data. Thus
provide exiv2 with the full raw image and let it find the most suitable
EXIF data chunk.

BUG: 346510

Diff Detail

Repository
R260 Gwenview
Lint
Lint Skipped
Unit
Unit Tests Skipped
tommo requested review of this revision.May 12 2019, 5:15 PM
tommo created this revision.
ngraham added a subscriber: ngraham.May 13 2019, 6:16 PM

Thanks for the nice simple fix. I actually don't have any RAW images I can use to test this. Any chance you could provide one or a few?

tommo added a comment.May 14 2019, 3:30 PM

I actually don't have any RAW images I can use to test this.

You actually do:

https://bugs.kde.org/show_bug.cgi?id=347574#c1
https://bugs.kde.org/show_bug.cgi?id=346510#c2

The same behavior applies for Canon .CR2 files, but I currently don't have time to upload 40 MiB.

ngraham accepted this revision.May 15 2019, 8:23 PM

Thank you!

This revision is now accepted and ready to land.May 15 2019, 8:23 PM
Closed by commit R260:a985ad14dc07: Fix incomplete EXIF data for RAW files (authored by tommo, committed by ngraham). · Explain WhyMay 15 2019, 8:29 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mlib/document/loadingdocumentimpl.cpp (10 lines)

Diff 57937

View Options

lib/document/loadingdocumentimpl.cpp

Loading...