Allow to include transfers in querytable reports
ClosedPublic

Authored by tbaumgart on May 12 2019, 8:48 AM.

Details

Summary

This change adds a switch to report configuration which allows to treat
transfers as income or expense in transaction reports (e.g. Transactions
by payee, etc.)

Diff Detail

Repository
R261 KMyMoney
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
tbaumgart requested review of this revision.May 12 2019, 8:48 AM
tbaumgart created this revision.
tbaumgart edited the summary of this revision. (Show Details)May 12 2019, 8:51 AM
tbaumgart added a reviewer: ostroffjh.

It compiles and runs fine. However, in testing, it brought up some questions. This is the default transactions by payee report where I did include transfers, organized by payees.

The first section includes includes four investment transactions - two add shares and two remove shares. Action is blank, where I would expect add or remove. The account is the equity account in that investment account, which while correct. However, why is this different from the final section in the report - explicitly for [Empty Payee] ? Also, I note "[No Tag]" only in transactions with "* UNASSIGNED *" category, even though it is blank (i.e., no tag) in most other transaction.

If I switch to "organized by Account" [No Tag] shows up for transactions with [Empty Payee] as well as unassigned category, which suggests it might be an artifact of the sorting and grouping.

I'm also tempted to open a new wishlist bug to suggest (in all reports?) that if sorting/grouping is by account, that equity accounts be sorted under the investment account they are in, not included at the top level (or perhaps make it an option.)

However, unless any of my comments actually suggest a problem with this specific change, I'll give a "ship it" and leave the others to separate discussion.

I checked your comments against current 5.0. I could not see any difference in the output (using the data I have), so that I don't see any impact of this change regarding the symptoms you see/reported. I will therefor ship it.

This revision was not accepted when it landed; it landed in state Needs Review.May 16 2019, 9:06 AM
This revision was automatically updated to reflect the committed changes.