KTorrent tries to look up a peer's country using a GeoIP database it tries to download that no longer exists and is no longer published in the same format.
This adapts KTorrent to the GeoIP database's new location as well as format.
BUG: 403054
Details
Details
- Apply the patch
- Start KTorrent
- Go to peers in an active torrent
- Check if the peer's country is shown correctly
Diff Detail
Diff Detail
- Repository
- R473 KTorrent
- Lint
Lint Skipped - Unit
Unit Tests Skipped
Comment Actions
Adding some reviewers...
Functionality-wise it seems to work fine here.
I noticed some problems though:
- It fails to build without libmaxminddb:
/usr/lib64/gcc/x86_64-suse-linux/9/../../../../x86_64-suse-linux/bin/ld: cannot find -lMaxminddb::Maxminddb collect2: error: ld returned 1 exit status
The lib should only be added to target_link_libraries if it was actually found.
- The new code uses KArchive, but that's optional. So it should also be disabled (and not added to target_link_libraries) if KArchive was not found.
- QString::null is deprecated (in Qt4 already, btw), please use QString() instead.
Comment Actions
Yes, it looks fine to me too. Please fix those issues that wbauer already mentioned and then you can commit (or ask somebody to commit if for you if you don't have commit access).
This comment was removed by trufanov.
Comment Actions
Hmm, regarding license, I guess it will be fine. KTorrent is GPLv2 or later. So GPLv3 would work.
Comment Actions
Yes, currently busy with something totally different, but that should be finished tomorrow.
Comment Actions
Unfortunately, this patch won't work as-is anymore because the "new" file is not available for download anymore either:
https://blog.maxmind.com/2019/12/18/significant-changes-to-accessing-and-using-geolite2-databases/
So it now shows an error message on startup as well:
Unknown host geolite.maxmind.com