Port ExternalPartStorage::self to C++11 singleton syntax.
ClosedPublic
Actions

Authored by dfaure on May 11 2019, 10:24 AM.

Details

Reviewers

dvratil
vkrause

Commits

Summary

Much simpler, and fixes a strange asan error about sInstance violating
ODR because defined twice in the test binary (which didn't seem right to me).

Test Plan

externalpartstoragetest now passes in the ASAN build

Repository

R165 Akonadi

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

dfaure requested review of this revision.May 11 2019, 10:24 AM

dfaure created this revision.

This revision is now accepted and ready to land.May 11 2019, 2:49 PM

This revision was automatically updated to reflect the committed changes.

			Path	Packages
M			src/private/externalpartstorage.cpp (10 lines)
M			src/private/externalpartstorage_p.h (2 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	57901	52b0868		May 11 2019, 10:24 AM	★	★
Diff 2	58015	c862746	R165:c1ead4aed3d5665ed60f6b8ee865f740aabb5be0	May 13 2019, 4:10 PM	★	★