Differential D21131

ScrollBar: Make it work as a horizontal scroll bar as well
ClosedPublic
Actions

Authored by apol on May 10 2019, 2:57 PM.

Details

Reviewers
mart
ngraham
Group Reviewers
Kirigami
Commits
R858:f7f99e8b8ca4: ScrollBar: Make it work as a horizontal scroll bar as well
Summary

It was only taking into account the height so always working as vertical.
This tracks the orientation property

BUG: 390351

Test Plan

Now case explained in the bug report works just fine, couldn't see any regressions.

Diff Detail

Repository
R858 Qt Quick Controls 2: Desktop Style
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
apol created this revision.May 10 2019, 2:57 PM
Restricted Application added a project: Plasma. · View Herald TranscriptMay 10 2019, 2:57 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
apol requested review of this revision.May 10 2019, 2:57 PM
mart accepted this revision.May 10 2019, 2:58 PM
This revision is now accepted and ready to land.May 10 2019, 2:58 PM
ngraham accepted this revision.May 10 2019, 3:00 PM
Closed by commit R858:f7f99e8b8ca4: ScrollBar: Make it work as a horizontal scroll bar as well (authored by apol). · Explain WhyMay 10 2019, 4:13 PM
This revision was automatically updated to reflect the committed changes.
broulik added a subscriber: broulik.May 12 2019, 10:19 AM

This patch causes the new notification KCM to crash, see Bug 407446

broulik added a comment.EditedMay 12 2019, 10:42 AM

I have a ListView inside a ScrollView [1] but for some reason controlRoot.position is NaN and then it ends up raising a SIGFPE in QCommonStyle. I don't understand why the position is bollocks, though. The position started being wrong when the WheelHandler stuff was rewritten.

[1] https://cgit.kde.org/plasma-desktop.git/tree/kcms/notifications/package/contents/ui/SourcesPage.qml#n82

ngraham added a comment.May 12 2019, 8:26 PM

In fact, all QML KCMs now crash. See https://bugs.kde.org/show_bug.cgi?id=407446.

Reverting this patch fixes the issue. However I suspect that this patch isn't the root cause and only exposed a deeper issue. Thoughts on how to proceed? We need to make sure this is fixed in some way before 5.59 is tagged, obviously.

Revision Contents
Changeset List

PathPackages
Morg.kde.desktop/ScrollBar.qml (9 lines)

Diff 57879

View Options

org.kde.desktop/ScrollBar.qml

Loading...