| smartins |
Give a warning and suggest replacement for functions from https://doc.qt.io/qt-5/qvariant-obsolete.html
The obvious thing would be adding a fixit, but one step at a time.
I'm usure about the correct level for this check. I don't see how it would produce a false-positive though
Inspired by D21107
Added test.
| No Linters Available |
| No Unit Test Coverage |
| Buildable 11725 | |
| Build 11743: arc lint + arc unit |
The preferred way is always to use one of the built-in clang warnings and make clazy spend less CPU cycles. I wonder why these are just not marked as deprecated.
Eitherway your check is useful and we can disable it for Qt >= 5.14 if we get to deprecate them upstream.
thanks!
| src/checks/level2/obsolete-qvariant-functions.cpp | ||
|---|---|---|
| 46 | cache the name, 1 line before | |
| 48 | no need to call c_str | |
| tests/obsolete-qvariant-functions/config.json | ||
| 2 | these minimums are probably a copy-paste from another config.json and not really needed ? | |
Also, please edit checks.json, add your check there, with level "0", since it doesn't have false positives.
And call:
./dev-scripts/generate.py --generate
That should move the files to the correct folder automatically.
Actually these functions have been deprecated for 5.14.
See qenums.cpp on how to validate the Qt version, and bailout early if preProcessorVisitor->qtVersion() >= 51400