Differential D21120

Fix memory leak of ItemRetrievalJobFactory in ItemRetrievalManager
ClosedPublic
Actions

Authored by dfaure on May 10 2019, 11:05 AM.

Tags

Subscribers

Details

Reviewers

Commits

R165:c2c92eb9aaa8: Fix memory leak of ItemRetrievalJobFactory in ItemRetrievalManager

Summary

It was never deleted. Fixed by making the ItemRetrievalManager own
the ItemRetrievalJobFactory in all cases.

Test Plan

ctest -R AkonadiServer-itemretrievertest in an ASAN build

Diff Detail

Repository

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

dfaure created this revision.May 10 2019, 11:05 AM

Restricted Application added a project: KDE PIM. · View Herald TranscriptMay 10 2019, 11:05 AM

dfaure requested review of this revision.May 10 2019, 11:05 AM

Harbormaster completed remote builds in B11719: Diff 57851.May 10 2019, 11:05 AM

dvratil accepted this revision.May 10 2019, 11:23 AM

This revision is now accepted and ready to land.May 10 2019, 11:23 AM

Closed by commit R165:c2c92eb9aaa8: Fix memory leak of ItemRetrievalJobFactory in ItemRetrievalManager (authored by dfaure). · Explain WhyMay 10 2019, 11:42 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			autotests/server/itemretrievertest.cpp (8 lines)
M			src/server/storage/itemretrievalmanager.h (4 lines)
M			src/server/storage/itemretrievalmanager.cpp (6 lines)

Diff 57853

autotests/server/itemretrievertest.cpp

Loading...

src/server/storage/itemretrievalmanager.h

Loading...

src/server/storage/itemretrievalmanager.cpp

Loading...