Added new option to use GlobalProtect with openconnect
ClosedPublic

Authored by avaldes on May 10 2019, 12:29 AM.

Details

Summary

This adds a new option to the dropdown and a new desktop file to create a connection to a Palo Alto / Global Protect network

FEATURE: 405389

Diff Detail

Repository
R116 Plasma Network Management Applet
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
avaldes created this revision.May 10 2019, 12:29 AM
Restricted Application added a project: Plasma. · View Herald TranscriptMay 10 2019, 12:29 AM
Restricted Application added a reviewer: jgrulich. · View Herald Transcript
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
avaldes requested review of this revision.May 10 2019, 12:29 AM

networkmanager-openconnect has added support in master for global protect, so now we can use it from plasma.

This was tested in my machine with Plasma 5.15.5 and the lastest networkmanager-openconnect.

The VPN works but I'm having an issue with the existing configuration options:

Unselecting the option "Use only for resources on this connection" in IPv4 > Routes doesn't work, I can access the network resources only available at the VPN but all my internet connections goes to the default internet route. I was able to solve this temporally by modifying the kernel routes. Is this intended?

I also tried changing the priority of the VPN to 0 and the default network connection to 2 but it didn't work.

networkmanager-openconnect has added support in master for global protect, so now we can use it from plasma.

This was tested in my machine with Plasma 5.15.5 and the lastest networkmanager-openconnect.

The VPN works but I'm having an issue with the existing configuration options:

Unselecting the option "Use only for resources on this connection" in IPv4 > Routes doesn't work, I can access the network resources only available at the VPN but all my internet connections goes to the default internet route. I was able to solve this temporally by modifying the kernel routes. Is this intended?

Do you mean this change didn't apply and when you opened the configuration again was still selected? If the change did apply and after you open the configuration again it was set as it was supposed to be, then it's most likely a NM issue.

I also tried changing the priority of the VPN to 0 and the default network connection to 2 but it didn't work.

It's autoconnect priority, this means that a connection with a higher priority will be automatically activated after restart instead of any other connection with a lower priority if available.

jgrulich added inline comments.May 10 2019, 8:51 AM
vpn/openconnect/CMakeLists.txt
62

It should be named plasmanetworkmanagement_openconnect_globalprotectui.desktop for consistency with the rest of openconnect types.

vpn/openconnect/openconnectwidget.cpp
190

Coding style, the "else if" should be on the same line as the "}" bracket.

193

Same here.

vpn/openconnect/plasmanetworkmanagement_openconnect_globalprotect.desktop
17 ↗(On Diff #57837)

I would use what NM use:
PAN GlobalProtect (openconnect)

18 ↗(On Diff #57837)

Same here:
Compatible with PAN GlobalProtect SSL VPN

avaldes updated this revision to Diff 57861.May 10 2019, 1:27 PM
  • Changes based on code review
avaldes added a comment.EditedMay 10 2019, 1:28 PM

networkmanager-openconnect has added support in master for global protect, so now we can use it from plasma.

This was tested in my machine with Plasma 5.15.5 and the lastest networkmanager-openconnect.

The VPN works but I'm having an issue with the existing configuration options:

Unselecting the option "Use only for resources on this connection" in IPv4 > Routes doesn't work, I can access the network resources only available at the VPN but all my internet connections goes to the default internet route. I was able to solve this temporally by modifying the kernel routes. Is this intended?

Do you mean this change didn't apply and when you opened the configuration again was still selected? If the change did apply and after you open the configuration again it was set as it was supposed to be, then it's most likely a NM issue.

I also tried changing the priority of the VPN to 0 and the default network connection to 2 but it didn't work.

It's autoconnect priority, this means that a connection with a higher priority will be automatically activated after restart instead of any other connection with a lower priority if available.

No, my question is about VPN connectivity with NM, the connection is active but not all traffic goes through the VPN, I would expect that if that option in Routes is off (use only for resources of this network) should make the VPN as the main connection, but it doesn't.

jgrulich accepted this revision.May 12 2019, 9:33 AM
This revision is now accepted and ready to land.May 12 2019, 9:33 AM

I can't land it, please merge @jgrulich

This revision was automatically updated to reflect the committed changes.