Differential D21105

Port widget settings window to QQC2+Kirigami FormLayout and modernize UI
ClosedPublic
Actions

Authored by ngraham on May 9 2019, 8:03 PM.

Details

Reviewers
drosca
Group Reviewers
VDG
Plasma
Maniphest Tasks
T10586: Modernize widget configuration settings
Commits
R115:9c3d0f2dffc2: Port widget settings window to QQC2+Kirigami FormLayout and modernize UI
Summary
  • Port to QQC2+Kirigami FormLayout style
  • Use standard import names
  • Adjust some strings to sound a bit more natural
Test Plan

All features still work.

The Audio Volume tab was already ported earlier and is not included in this patch

Diff Detail

Repository
R115 Plasma Audio Volume Applet
Branch
modernize-widget-settings-window (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 11697
Build 11715: arc lint + arc unit
ngraham created this revision.May 9 2019, 8:03 PM
Restricted Application added a project: Plasma. · View Herald TranscriptMay 9 2019, 8:03 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
ngraham requested review of this revision.May 9 2019, 8:03 PM
ngraham added a comment.May 13 2019, 2:42 PM

Ping. I'd like to get this in before the string freeze so it can be a part of Plasma 5.16 so we can complete T10586 in that release.

drosca accepted this revision.May 13 2019, 3:01 PM
This revision is now accepted and ready to land.May 13 2019, 3:01 PM
Closed by commit R115:9c3d0f2dffc2: Port widget settings window to QQC2+Kirigami FormLayout and modernize UI (authored by ngraham). · Explain WhyMay 13 2019, 3:59 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mapplet/contents/ui/ConfigGeneral.qml (112 lines)

Diff 57818

View Options

applet/contents/ui/ConfigGeneral.qml

Loading...