Port widget settings window to QQC2+Kirigami FormLayout
ClosedPublic
Actions

Authored by ngraham on May 9 2019, 7:32 PM.

Details

Reviewers

jgrulich

Group Reviewers

VDG

Maniphest Tasks

T10586: Modernize widget configuration settings

Commits

Summary

Port to QQC2+Kirigami FormLayout style
Use standard import names
Adjust one string to sound a bit more natural (configuration is implicit and does not need to be mentioned)

Test Plan

Repository

R116 Plasma Network Management Applet

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Restricted Application added 1 blocking reviewer(s): jgrulich. · View Herald Transcript

Restricted Application added a subscriber: plasma-devel. · View Herald Transcript

ngraham requested review of this revision.May 9 2019, 7:32 PM

This revision is now accepted and ready to land.May 10 2019, 5:54 AM

This revision was automatically updated to reflect the committed changes.

			Path	Packages
M			applet/contents/ui/configGeneral.qml (42 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	57815	dc4a08a		May 9 2019, 7:32 PM	★	★
Diff 2	57876	dc4a08a	R116:48543b1b119253276069fd9ed867a190a970d3ee	May 10 2019, 4:02 PM	★	★

Commit	Tree	Parents	Author	Summary	Date
125959ea1495	725a9f73b9e3	dc4a08a70417	Nate Graham	Port widget settings window to QQC2+Kirigami FormLayout (Show More…)	May 9 2019, 7:29 PM