This allows the icon theme to provide a donate icon using the currency symbol, e.g. help-donate-eur.
In case such an icon doesn't exist the icon fallback mechanism chooses help-donate again.
Details
- Reviewers
ngraham - Group Reviewers
Frameworks VDG - Commits
- R265:80cc612a50e9: Use locale currency for donate icon
English US (default icon)
German locale
(obviously needs proper icons ;))
Diff Detail
- Repository
- R265 KConfigWidgets
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Is there a list of currency codes somewhere so that VDG can know what icons we'll need to make to fully support this?
https://en.wikipedia.org/wiki/ISO_4217#Active_codes if you want to have fun with it I guess :D
For obvious reasons I'd recommend only going for the major currencies :)
I've had a quick look at a part of our website visits and the following currencies would be the most relevant based on that:
- EUR
- USD (this is actually the default icon so it's not needed and as far as I can see AUD and CAD have the same symbol)
- RUB
- GBP
- CNY
- BRR
- INR
- MXN
- PLN
- UAH
- TRY
- SEK
- JPY
- ARS
- CHF
(in that order)
The first 5-10 or so are also in line with localization statistics I have in the back of my mind from a while ago (from Kubuntu I think?), so this list should be fairly representative as far as how many of our current users are affected by that currency.
src/kstandardaction.cpp | ||
---|---|---|
202 | else iconName = "help-donate" ? |
src/kstandardaction.cpp | ||
---|---|---|
202 | That's the default specified in the struct already |
Filed an icon request bug for Breeze icons: https://bugs.kde.org/show_bug.cgi?id=407372
In the meantime I think this is safe enough to land given that the fallback mechanic will result in no visual changes until we actually get new icons.