Differential D21095

Use qOverload instead of static_cast inside connect
ClosedPublic
Actions

Authored by davidre on May 9 2019, 11:58 AM.

Details

Reviewers
ngraham
Group Reviewers
Spectacle
Commits
R166:71232f7ef5fb: Use qOverload instead of static_cast inside connect
Summary

Since we are now using C++14 use qOverload which is more readable than the static_cast equivalent.

Test Plan

Spectacle still builds and has the same behavior as before.

Diff Detail

Repository
R166 Spectacle
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
davidre created this revision.May 9 2019, 11:58 AM
Restricted Application added a project: Spectacle. · View Herald TranscriptMay 9 2019, 11:58 AM
davidre requested review of this revision.May 9 2019, 11:58 AM
davidre added a comment.May 15 2019, 2:34 PM

Pinging this one too

ngraham accepted this revision.May 29 2019, 4:39 PM
ngraham added a subscriber: ngraham.

Whoops, sorry for letting this get lost.

This revision is now accepted and ready to land.May 29 2019, 4:39 PM
Closed by commit R166:71232f7ef5fb: Use qOverload instead of static_cast inside connect (authored by davidre). · Explain WhyMay 30 2019, 12:24 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 58907

View Options

src/Gui/KSWidget.cpp

Loading...
View Options

src/Gui/SettingsDialog/GeneralOptionsPage.cpp

Loading...
View Options

src/Gui/SmartSpinBox.cpp

Loading...