- Port to QQC2+Kirigami FormLayout style, except for the SpinBox which cannot handle decimal values well in the QQC2 version
- Use standard import names
- Adjust some strings to sound a bit more natural
Details
- Reviewers
filipf - Group Reviewers
VDG Plasma - Maniphest Tasks
- T10586: Modernize widget configuration settings
- Commits
- R114:864c0bf28a09: [System Load Viewer] Port settings window to QQC2+Kirigami FormLayout and…
- All features still work
- Settings loaded correctly when the window appears and saved correctly
Diff Detail
- Repository
- R114 Plasma Addons
- Branch
- monitor-modernize-settings-window (branched from master)
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 11657 Build 11675: arc lint + arc unit
Skeleton of a QQC2 SpinBox implementation: P381
The number in the box wasn't mouse-selectable and I wasn't able to get the suffix working properly. In the end I opted to stay with the QQC1 version for now.
applets/systemloadviewer/package/contents/ui/ColorSettings.qml | ||
---|---|---|
41 | To better align the checkbox in this layout with the other layout you can set twinFormLayouts so the first one points to the second one and get: Or you could go all the way and also make the second one point to the first one and get: Personally I like solution no.1 more. | |
119 | We're having weird resizing behavior because we haven't anchored the two forms to each other: We need to anchor the bottom layout to the top one so just assign an ID to the first layout and then do something like: anchors.top: manualColors.bottom | |
applets/systemloadviewer/package/contents/ui/GeneralSettings.qml | ||
57 | Indentation is not working due to uppercase typo. Just change to Kirigami.Units.gridUnit and it works! |
applets/systemloadviewer/package/contents/ui/ColorSettings.qml | ||
---|---|---|
24 | Don't need the import anymore |