Differential D21046

Fix hsv effect when applied to image
ClosedPublic
Actions

Authored by andreagenor on May 6 2019, 2:33 PM.

Details

Reviewers
tcanabrava
broulik
Commits
R374:370ddfc27aae: Fix hsv effect when applied to image
Summary

Signed-off-by: André Agenor <andreagenor@icloud.com>
The image tend to be darken when effect is applied

Diff Detail

Repository
R374 KolourPaint
Branch
fix/effect-equalizer
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 11591
Build 11609: arc lint + arc unit
andreagenor requested review of this revision.May 6 2019, 2:33 PM
andreagenor created this revision.
tcanabrava added a comment.May 6 2019, 2:38 PM

can you put a screenshoot of the before / after ? I can't really read math.

broulik added a comment.May 6 2019, 2:44 PM

Works well!


Left is with this patch, right is without

andreagenor added a comment.May 6 2019, 2:45 PM
In D21046#461591, @tcanabrava wrote:

can you put a screenshoot of the before / after ? I can't really read math.

Before

After

tcanabrava accepted this revision.May 8 2019, 9:06 AM
This revision is now accepted and ready to land.May 8 2019, 9:06 AM
Closed by commit R374:370ddfc27aae: Fix hsv effect when applied to image (authored by andreagenor). · Explain WhyMay 8 2019, 12:01 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mimagelib/effects/kpEffectHSV.cpp (46 lines)

Diff 57642

View Options

imagelib/effects/kpEffectHSV.cpp

Loading...