Differential D21044

Remove kde connect context menu entries when host dies
ClosedPublic
Actions

Authored by broulik on May 6 2019, 7:58 AM.

Details

Reviewers
fvogt
Group Reviewers
Plasma
Commits
R856:7b11fee2b906: Remove kde connect context menu entries when host dies
Summary

They don't work without a host and up on (re)starting we get a deviceAdded signal for every device leading to duplicate menu id errors.

Test Plan

killed plasma-browser-integration-host process, didn't get a warning about duplicate ids on extension console anymore
Disabling and enabling kde connect integration properly adds and removes the entries

Diff Detail

Repository
R856 Plasma Browser Integration
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik created this revision.May 6 2019, 7:58 AM
Restricted Application added a project: Plasma. · View Herald TranscriptMay 6 2019, 7:58 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
broulik requested review of this revision.May 6 2019, 7:58 AM
fvogt accepted this revision.May 7 2019, 7:34 AM
This revision is now accepted and ready to land.May 7 2019, 7:34 AM
Closed by commit R856:7b11fee2b906: Remove kde connect context menu entries when host dies (authored by broulik). · Explain WhyMay 7 2019, 8:05 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mextension/extension.js (18 lines)

Diff 57698

View Options

extension/extension.js

Loading...