When Vaults are mounted and show up in the mtab, use the matching icon.
As these mounts are only visible in the decrypted state, use the
folder-decrypted icon.
Details
Details
- Reviewers
ngraham hallas - Group Reviewers
Frameworks - Commits
- R245:ee77083102b1: [Fstab] Use folder-decrypted icon for encrypting fuse mounts
Vault shows up with matching icon
Diff Detail
Diff Detail
- Repository
- R245 Solid
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
| src/solid/devices/backends/fstab/fstabdevice.cpp | ||
|---|---|---|
| 62 | Would it make sense to wrap this in a function with a more expressive name like: isEncryptedFilesystem or isValutFilesystem? Then we could use the same function in fstabhandling.cpp:126 | |
| 91 | I think a switch here (without a default case) would be nice. This would allow us to get the compiler to tell us to update this list if new storage types are added. | |
| 172 | Why do we create a new FstabNetworkShare everytime this function is called with NetworkShare but we return the same object instance when it is a StorageAccess? | |
| src/solid/devices/backends/fstab/fstabdevice.cpp | ||
|---|---|---|
| 62 | I don't think there is much to gain here - as the function is trivial, we should inline it. To keep the code easy to understand, the function name has to be really expressive. On the next fuse filesystem added, it may become quite different. | |
| 172 | The storageAccess is also used internally, for the emblems() method. Creating it on each call would be to expensive, especially as it has quite some signals connected, also DBus signals. | |