avoid sending wrong or empty metadata to mpris2 interface
ClosedPublic

Authored by mgallien on May 5 2019, 8:58 PM.

Details

Summary

fix a crash with empty album metadata

Test Plan

play a track with no album metadata no longer crash with a dbus error

Diff Detail

Repository
R255 Elisa
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
mgallien requested review of this revision.May 5 2019, 8:58 PM
mgallien created this revision.
broulik added a subscriber: broulik.May 5 2019, 9:29 PM

Does Plasma crash because of this or Elisa?

Does Plasma crash because of this or Elisa?

Elisa because it tries to encode a null QDBusVariant.

Ping.
I would like if possible to get this in before end of next week to have in the 0.4.0 release.

ngraham accepted this revision.May 13 2019, 6:01 PM

Works for me, thanks.

This revision is now accepted and ready to land.May 13 2019, 6:01 PM
This revision was automatically updated to reflect the committed changes.