Index: src/calendar.cpp =================================================================== --- src/calendar.cpp +++ src/calendar.cpp @@ -184,7 +184,7 @@ { d->mTimeZone = d->timeZoneIdSpec(timeZoneId); - doSetTimeZone(d->mTimeZone); + doSetTimeZone(d->mTimeZone); //NOLINT false clang-analyzer-optin.cplusplus.VirtualCall } //@cond PRIVATE Index: src/freebusy.cpp =================================================================== --- src/freebusy.cpp +++ src/freebusy.cpp @@ -90,15 +90,15 @@ FreeBusy::FreeBusy(const QDateTime &start, const QDateTime &end) : d(new KCalCore::FreeBusy::Private(this)) { - setDtStart(start); - setDtEnd(end); + setDtStart(start); //NOLINT false clang-analyzer-optin.cplusplus.VirtualCall + setDtEnd(end); //NOLINT false clang-analyzer-optin.cplusplus.VirtualCall } FreeBusy::FreeBusy(const Event::List &events, const QDateTime &start, const QDateTime &end) : d(new KCalCore::FreeBusy::Private(this)) { - setDtStart(start); - setDtEnd(end); + setDtStart(start); //NOLINT false clang-analyzer-optin.cplusplus.VirtualCall + setDtEnd(end); //NOLINT false clang-analyzer-optin.cplusplus.VirtualCall d->init(events, start, end); } @@ -253,7 +253,6 @@ void FreeBusy::sortList() { std::sort(d->mBusyPeriods.begin(), d->mBusyPeriods.end()); - return; } void FreeBusy::addPeriods(const Period::List &list) Index: src/incidence.cpp =================================================================== --- src/incidence.cpp +++ src/incidence.cpp @@ -327,7 +327,7 @@ setSchedulingID(QString(), CalFormat::createUniqueId()); setRevision(0); - setLastModified(nowUTC); + setLastModified(nowUTC); //NOLINT false clang-analyzer-optin.cplusplus.VirtualCall } void Incidence::setLastModified(const QDateTime &lm) Index: src/memorycalendar.cpp =================================================================== --- src/memorycalendar.cpp +++ src/memorycalendar.cpp @@ -117,14 +117,14 @@ void insertIncidence(const Incidence::Ptr &incidence); Incidence::Ptr incidence(const QString &uid, - const IncidenceBase::IncidenceType type, + IncidenceBase::IncidenceType type, const QDateTime &recurrenceId = {}) const; Incidence::Ptr deletedIncidence(const QString &uid, const QDateTime &recurrenceId, - const IncidenceBase::IncidenceType type) const; + IncidenceBase::IncidenceType type) const; - void deleteAllIncidences(const IncidenceBase::IncidenceType type); + void deleteAllIncidences(IncidenceBase::IncidenceType type); }; //@endcond @@ -143,7 +143,7 @@ MemoryCalendar::~MemoryCalendar() { - close(); + close(); //NOLINT false clang-analyzer-optin.cplusplus.VirtualCall delete d; } @@ -221,7 +221,7 @@ } //@cond PRIVATE -void MemoryCalendar::Private::deleteAllIncidences(const Incidence::IncidenceType incidenceType) +void MemoryCalendar::Private::deleteAllIncidences(Incidence::IncidenceType incidenceType) { QHashIteratori(mIncidences[incidenceType]); while (i.hasNext()) { @@ -234,7 +234,7 @@ } Incidence::Ptr MemoryCalendar::Private::incidence(const QString &uid, - const Incidence::IncidenceType type, + Incidence::IncidenceType type, const QDateTime &recurrenceId) const { Incidence::List values = ::values(mIncidences[type], uid); @@ -255,8 +255,8 @@ Incidence::Ptr MemoryCalendar::Private::deletedIncidence(const QString &uid, - const QDateTime &recurrenceId, - const IncidenceBase::IncidenceType type) const + const QDateTime &recurrenceId, + IncidenceBase::IncidenceType type) const { if (!q->deletionTracking()) { return Incidence::Ptr(); Index: src/recurrencerule.cpp =================================================================== --- src/recurrencerule.cpp +++ src/recurrencerule.cpp @@ -1497,7 +1497,6 @@ Constraint interval(d->getNextValidDateInterval(start, recurrenceType())); // Constraint::matches is quite efficient, so first check if it can occur at // all before we calculate all actual dates. - match = false; Constraint intervalm = interval; do { match = intervalm.matches(startDay, recurrenceType());