Differential D21035

Remove disconnected network devices from Network Monitor.
Needs ReviewPublic
Actions

Authored by bernhardu on May 5 2019, 3:43 PM.

Details

Reviewers
mart
Group Reviewers
Plasma
Summary

USB network devices or VirtualBox bridges are just
temporarily up and active in the system.

The Network Monitor Widget automatically adds such interfaces
when such devices get connected.
Unfortunately it does not remove them when disconnected.

This patch tries to implement also the removal and
works in current Debian testing/buster.

But it touches the common file Applet.qml, so it may have unwanted
side effects to other widgets in its current state.

BUG: 411106
FIXED-IN: 5.17.0

Diff Detail

Repository
R120 Plasma Workspace
Lint
Lint Skipped
Unit
Unit Tests Skipped
bernhardu created this revision.May 5 2019, 3:43 PM
Restricted Application added a project: Plasma. · View Herald TranscriptMay 5 2019, 3:43 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
bernhardu requested review of this revision.May 5 2019, 3:43 PM
ngraham edited reviewers, added: Plasma, jgrulich; removed: Plasma: Workspaces.Aug 23 2019, 7:52 PM
ngraham edited the summary of this revision. (Show Details)
jgrulich added a subscriber: mart.Aug 26 2019, 11:37 AM

Looks good to me, but I'm not the author of this code. I would rather let @mart to approve this review.

applets/systemmonitor/common/contents/ui/Applet.qml
71

This variable doesn't seem to be used.

jgrulich edited reviewers, added: mart; removed: jgrulich.Aug 26 2019, 11:37 AM

Revision Contents
Changeset List

Diff 57598

View Options

applets/systemmonitor/common/contents/ui/Applet.qml

Loading...
View Options

applets/systemmonitor/net/contents/ui/net.qml

Loading...