Differential D21032

Labelwidget
ClosedPublic
Actions

Authored by Murmele on May 5 2019, 1:43 PM.

Details

Reviewers
asemke
Commits
R262:62e0fc0afeaa: Fixes and improvements in LabelWidget:
Summary
  • change from old signal slot to new one
  • add background color slot, because it was frogotten
  • set text family when loading text from labels
  • enable alpha in KColorChanger

Diff Detail

Repository
R262 LabPlot
Lint
Lint Skipped
Unit
Unit Tests Skipped
Murmele created this revision.May 5 2019, 1:43 PM
Restricted Application added a project: KDE Edu. · View Herald TranscriptMay 5 2019, 1:43 PM
Restricted Application added a subscriber: kde-edu. · View Herald Transcript
Murmele requested review of this revision.May 5 2019, 1:43 PM
Murmele updated this revision to Diff 57817.May 9 2019, 7:36 PM
Murmele edited the summary of this revision. (Show Details)
Murmele retitled this revision from [WIP] Labelwidget to Labelwidget.May 9 2019, 7:55 PM
Murmele updated this revision to Diff 59897.Jun 16 2019, 7:27 AM
  • added comments
  • don't set backgroundcolor and fontcolor variable in the labelwidget, because the colors are already included in the HTML code of the text
Murmele updated this revision to Diff 60322.Jun 22 2019, 11:09 AM
Murmele updated this revision to Diff 60339.Jun 22 2019, 12:38 PM
asemke accepted this revision.Jun 22 2019, 3:35 PM

We still need to show the widgets for the background color in case LaTeX is used. I'll slightly modify your patch and land it.

This revision is now accepted and ready to land.Jun 22 2019, 3:35 PM
Closed by commit R262:62e0fc0afeaa: Fixes and improvements in LabelWidget: (authored by asemke). · Explain WhyJun 22 2019, 3:40 PM
This revision was automatically updated to reflect the committed changes.

Showing Only Differences

This revision modifies 2 more files that are hidden because they were not modified between selected diffs and they have no inline comments.

Revision Contents
Changeset List

Diff 60339

View Options

src/kdefrontend/widgets/LabelWidget.cpp

Loading...