Differential D21012

[PanelView] Update mask as last on resize event (& move one for consistency)
ClosedPublic
Actions

Authored by kossebau on May 4 2019, 11:54 AM.

Details

Reviewers
broulik
Group Reviewers
Plasma
Commits
R120:b51fd4bab2a5: [PanelView] Update mask as last on resize event (& move one for consistency)
Summary

The mask of a panel depends on things like borders set or window size,
but nothing else on it. So it should be updated as last in the queue of
things to update.
There might be still state changes not properly propagated, but this is
a move in the more expected direction.

Diff Detail

Repository
R120 Plasma Workspace
Branch
updatemasklast
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 11538
Build 11556: arc lint + arc unit
kossebau created this revision.May 4 2019, 11:54 AM
Restricted Application added a project: Plasma. · View Herald TranscriptMay 4 2019, 11:54 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
kossebau requested review of this revision.May 4 2019, 11:54 AM
kossebau added a comment.May 4 2019, 11:58 AM

@broulik Could you tell if this improves the bug you found about "change resolution in plasma, the panel mask stays incorrect"?

apol added a subscriber: apol.May 4 2019, 1:05 PM

That makes a lot of sense. +1
I'm not sure how to reproduce the issue but I've seen it happen many times.

broulik accepted this revision.May 5 2019, 9:36 PM

Makes sense and works fine, thanks

This revision is now accepted and ready to land.May 5 2019, 9:36 PM
Closed by commit R120:b51fd4bab2a5: [PanelView] Update mask as last on resize event (& move one for consistency) (authored by kossebau). · Explain WhyMay 5 2019, 10:32 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mshell/panelview.cpp (5 lines)

Diff 57540

View Options

shell/panelview.cpp

Loading...