Differential D21007

Review kate config pages to improve maintenance friendliness
ClosedPublic
Actions

Authored by loh.tar on May 4 2019, 5:53 AM.

Details

Reviewers
dhaumann
Group Reviewers
KTextEditor
Commits
R39:2af8bdae9ae2: Review kate config pages to improve maintenance friendliness
Summary
  • Use new signal/slot style by new added helper functions
  • Unified comments, added some new, removed some obsolete
Test Plan

I hope nothing got damaged

Diff Detail

Repository
R39 KTextEditor
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
loh.tar created this revision.May 4 2019, 5:53 AM
Restricted Application added projects: Kate, Frameworks. · View Herald TranscriptMay 4 2019, 5:53 AM
Restricted Application added subscribers: kde-frameworks-devel, kwrite-devel. · View Herald Transcript
loh.tar requested review of this revision.May 4 2019, 5:53 AM
dhaumann accepted this revision.May 4 2019, 6:43 AM
dhaumann added a subscriber: dhaumann.

I guess this is more easy on the eyes.

Alternatively, one could consider making observeCanges a free function, but please commit for now.

src/dialogs/katedialogs.cpp
156

Typo: sililar

This revision is now accepted and ready to land.May 4 2019, 6:43 AM
Closed by commit R39:2af8bdae9ae2: Review kate config pages to improve maintenance friendliness (authored by loh.tar). · Explain WhyMay 4 2019, 6:58 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 57522

View Options

src/dialogs/kateconfigpage.h

Loading...
View Options

src/dialogs/kateconfigpage.cpp

Loading...
View Options

src/dialogs/katedialogs.cpp

Loading...