Add global menu by using qml native menu components
ClosedPublic

Authored by mgallien on May 3 2019, 8:24 PM.

Details

Summary

Seems to do the job by providing a global menu and not clutering the UI
when plasma-workspace does not provide a global menu.

BUG: 400335

Test Plan

Works with Plasma 5.14 and a global menu applet

Diff Detail

Repository
R255 Elisa
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
mgallien requested review of this revision.May 3 2019, 8:24 PM
mgallien created this revision.

Targeted at master branch only.

Seems to work perfectly. My only UI suggestion is to hide the hamburger button in the window when exporting the menu like this.

Also, there seems to be some code redundancy between this menu and the in-window hamburger menu. Can they share the same code somehow?

trmdi added a subscriber: trmdi.EditedMay 4 2019, 8:08 AM

Why is it like this:

instead of this?

I mean, can we have some more Menu instead of only Elisa ?

Seems to work perfectly. My only UI suggestion is to hide the hamburger button in the window when exporting the menu like this.

I will have to investigate to know what is possible.

Also, there seems to be some code redundancy between this menu and the in-window hamburger menu. Can they share the same code somehow?

The idea is to do the work to allow native menu to be usable and remove the old one. Currently, quite some things are not working. I should probably add a WIP prefix.

I wanted to get feedback on how well it would be working given it seemed working on my setup.

Why is it like this:

instead of this?

I mean, can we have some more Menu instead of only Elisa ?

Currently, Elisa is not really an application built around the idea of having a big and complex application menu bar.
This is the reason why you see only one menu.

trmdi added a comment.May 5 2019, 8:52 AM

Currently, Elisa is not really an application built around the idea of having a big and complex application menu bar.
This is the reason why you see only one menu.

No need a complex menu bar, but there should be *some* ones. For example: File | View | Playlist | Settings | Help (just an example)

Elisa Is anybody interested to work on this ?

Probably best to get this in rather than making it perfect first. Iteration can come later.

The one thing that I think should be changed before getting it in is that the menu should have a different name. "Elisa Elisa" isn't very user-friendly. Maybe "Elisa Control" or "Elisa Actions"?

mgallien planned changes to this revision.Sep 8 2019, 8:42 PM

Probably best to get this in rather than making it perfect first. Iteration can come later.

The one thing that I think should be changed before getting it in is that the menu should have a different name. "Elisa Elisa" isn't very user-friendly. Maybe "Elisa Control" or "Elisa Actions"?

Thanks for your help.

I will do that and update the review.

Sorry for my late answer.

mgallien updated this revision to Diff 65704.Sep 9 2019, 8:54 PM
  • export the menu as "Application Menu"

it would be hard to do much better given the current limitations of the native global menu components

I fear I lack time to work upstream on this even if that should be the only right way to handle this.

ngraham accepted this revision.Sep 9 2019, 9:58 PM

This is fine for now IMO. We can polish it later.

This revision is now accepted and ready to land.Sep 9 2019, 9:58 PM
This revision was automatically updated to reflect the committed changes.