Details
Details
- Reviewers
apol mart - Group Reviewers
Plasma - Commits
- R242:3b950f38ccd5: Update *.qmltypes to current API of QML modules
Diff Detail
Diff Detail
- Repository
- R242 Plasma Framework (Library)
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Comment Actions
I am not exactly sure why the diff is so large, compared to last run in 2017? Done against Qt 5.12.3 on my openSUSE TW.
I also got the log ouput
Could not find any platform plugin
not sure if this is any relevant on calculating the deps, should not, or?
Diff anticipates already the acceptance of D20999 (which I actually found when looking at this diffs :) ).
Comment Actions
Looks like we were exporting the qmltypes for QtQuick Controls within the calendar file?
LGTM overall, but an additional set of eyes would be useful.
Comment Actions
Anyone else who could give this a check?
Have to tell that I am not sure where I could really test the changes, for now I just looked at the data of the files only. And also wonder if anyone really relies on these, given they were 2 years old and missed some changes in the API.