Differential D20997

Simplify applet keyboard shortcut chooser's explanatory text
ClosedPublic
Actions

Authored by ngraham on May 3 2019, 4:13 PM.

Details

Reviewers
ndavis
Group Reviewers
VDG
Plasma
Commits
R119:64e48e87656b: Simplify applet keyboard shortcut chooser's explanatory text
Summary

The old test was unnecessarily wordy and contained grammar errors. This patch simplifies
the description using plainer and more comprehensible language.

Test Plan

Diff Detail

Repository
R119 Plasma Desktop
Branch
simplify-keyboard-shortcut-description (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 11502
Build 11520: arc lint + arc unit
ngraham created this revision.May 3 2019, 4:13 PM
Restricted Application added a project: Plasma. · View Herald TranscriptMay 3 2019, 4:13 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
ngraham requested review of this revision.May 3 2019, 4:13 PM
ndavis accepted this revision.May 3 2019, 6:48 PM
ndavis added a subscriber: ndavis.

Yeah, I wonder how often people's eyes glaze over by the time they get halfway through the old description.

This revision is now accepted and ready to land.May 3 2019, 6:48 PM
ngraham added a comment.May 3 2019, 6:50 PM

Mine certainly did. :)

Closed by commit R119:64e48e87656b: Simplify applet keyboard shortcut chooser's explanatory text (authored by ngraham). · Explain WhyMay 3 2019, 6:51 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 57480

View Options

desktoppackage/contents/configuration/ConfigurationShortcuts.qml

Loading...