Differential D20992

Adapt to Grantlee printing changes
ClosedPublic
Actions

Authored by vkrause on May 3 2019, 4:10 PM.

Details

Reviewers
dvratil
Commits
R204:4783100cb88a: Adapt to Grantlee printing changes

Diff Detail

Repository
R204 KAddressBook
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
vkrause created this revision.May 3 2019, 4:10 PM
Restricted Application added a project: KDE PIM. · View Herald TranscriptMay 3 2019, 4:10 PM
Restricted Application added a subscriber: kde-pim. · View Herald Transcript
vkrause requested review of this revision.May 3 2019, 4:10 PM
dvratil requested changes to this revision.May 4 2019, 7:29 AM
dvratil added a subscriber: dvratil.
dvratil added inline comments.
src/printing/grantlee/grantleeprintstyle.h
41

Could be on the stack, after all?

This revision now requires changes to proceed.May 4 2019, 7:29 AM
vkrause updated this revision to Diff 57526.May 4 2019, 9:03 AM

Create GrantleePrint on the stack.

dvratil accepted this revision.May 4 2019, 9:36 AM

Thanks!

This revision is now accepted and ready to land.May 4 2019, 9:36 AM
Closed by commit R204:4783100cb88a: Adapt to Grantlee printing changes (authored by vkrause). · Explain WhyMay 4 2019, 10:43 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 57534

View Options

CMakeLists.txt

Loading...
View Options

src/printing/grantlee/grantleeprintstyle.h

Loading...
View Options

src/printing/grantlee/grantleeprintstyle.cpp

Loading...
View Options

src/printing/grantlee/themes/big-theme-example/theme.html

Loading...