Differential D20990

[Fstab] Preparatory work for enabling filesystems beyond NFS/SMB
ClosedPublic
Actions

Authored by bruns on May 3 2019, 4:08 PM.

Details

Reviewers
ngraham
hallas
Group Reviewers
Frameworks
Commits
R245:7aad0e183b3d: [Fstab] Preparatory work for enabling filesystems beyond NFS/SMB
Summary

Currently, the fstab backend only lists NFS and SMB share, although
the majority of the code could handle any other file system, e.g.
encfs.fuse used for Vaults.

Fix up description to make it more generic, and restructure
devicesFromQuery() to allow extension for other Solid interfaces. The
apparent code duplication will go away as soon as e.g. the
StorageVolume interface has to be handled.

Diff Detail

Repository
R245 Solid
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
bruns created this revision.May 3 2019, 4:08 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptMay 3 2019, 4:08 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
bruns requested review of this revision.May 3 2019, 4:08 PM
ngraham accepted this revision.May 3 2019, 6:22 PM
This revision is now accepted and ready to land.May 3 2019, 6:22 PM
Closed by commit R245:7aad0e183b3d: [Fstab] Preparatory work for enabling filesystems beyond NFS/SMB (authored by bruns). · Explain WhyMay 3 2019, 6:46 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 57501

View Options

src/solid/devices/backends/fstab/fstabmanager.cpp

Loading...