| ngraham |
If you have any actions in your GridDelegate, activating them would previously
cause the delegate's onClicked signal to fire, which isn't always desirable.
The logic behind the original code was that it was supposed to set that item
as the current one in the gridview, so a little bit of working around nested
delegates (understandably) not forwarding models, and we have the ability to
set the delegate as the current item.
See any KCM which performs an action on clicking the thumbnail, and which has actions
| No Linters Available |
| No Unit Test Coverage |
| Buildable 11484 | |
| Build 11502: arc lint + arc unit |
-1
Most KCMs actually use onClicked to update the selected plugin and other bits. They don't actually set currentIndex on the ListView directly but have it updated based on whatever current scheme or theme etc is selected.
Can it be fixed such that the onClicked isn't fired when the action is invoked? From what I can see the actions don't rely on currentIndex
Unless i'm misunderstanding you, that's precisely what this code does - onClicked still gets triggered when clicking the thumbnail itself, this patch only affects the action buttons. The previous code was specifically added to set the current index, according to Nate in https://phabricator.kde.org/D18649#459586 :)
oh, crap, right, I thought that was the delegate code, not the buttons.
I think it just shouldn't do anything then since when changing the currentIndex if the KCM isn't prepared for that might cause the visual index and actual selected setting to become out of sync.