Differential D20985

Set compression to 50 is the format is png
ClosedPublic
Actions

Authored by davidre on May 3 2019, 9:18 AM.

Details

Reviewers
cfeck
ngraham
Group Reviewers
Spectacle
Commits
R166:879249b62570: Set compression to 50 is the format is png
Summary

This reverts commit 0f259d9be2bd6be8e8e28b46f22e5ba7d5720273.

If no value for compression is set the png handler will fallback to using quality to determine compression resulting in huge files. See also the Discussion in D19591.

BUG: 406263
FIXED-IN: 19.04.1

Test Plan

Save png with quality configured to 100.
The picture file should have a reasonable size.

Diff Detail

Repository
R166 Spectacle
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
davidre created this revision.May 3 2019, 9:18 AM
Restricted Application added a project: Spectacle. · View Herald TranscriptMay 3 2019, 9:18 AM
Restricted Application added a subscriber: Spectacle. · View Herald Transcript
davidre requested review of this revision.May 3 2019, 9:18 AM
davidre edited the summary of this revision. (Show Details)May 3 2019, 9:20 AM
davidre added reviewers: Spectacle, cfeck, ngraham.
ngraham edited the summary of this revision. (Show Details)May 3 2019, 1:32 PM

Works perfectly, thanks. @cfeck, does this look good?

ngraham accepted this revision.May 3 2019, 1:33 PM
This revision is now accepted and ready to land.May 3 2019, 1:33 PM
shubham added a subscriber: shubham.May 5 2019, 3:30 AM
shubham added inline comments.
src/ExportManager.cpp
295

Please use QLatin1String("png")

ngraham added inline comments.May 5 2019, 5:55 PM
src/ExportManager.cpp
295

format is a QByteArray, which can't be compared to a QLatin1String like that.

Closed by commit R166:879249b62570: Set compression to 50 is the format is png (authored by davidre, committed by ngraham). · Explain WhyMay 5 2019, 6:00 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/ExportManager.cpp (9 lines)
Msrc/SpectacleConfig.cpp (2 lines)

Diff 57602

View Options

src/ExportManager.cpp

Loading...
View Options

src/SpectacleConfig.cpp

Loading...