Differential D20983

Exclude .gcode and virtual machine files from indexing consideration
ClosedPublic
Actions

Authored by ngraham on May 3 2019, 2:42 AM.

Details

Reviewers
bruns
Group Reviewers
Baloo
Commits
R293:7f9ecb88253c: Exclude .gcode and virtual machine files from indexing consideration
Summary

gcode files are the CNC machine/3D printer equivalent of build files and contain no
data that is useful to index.

The excluded VM-related files are huge, frequently-changing,
and contain no indexable data.

Test Plan

Baloo no longer wastes time and kernel watches trying to index my gcode and Virtualbox
disk image files. It also no longer notices every single change to the virtualbox files while
a VM is being used.

Diff Detail

Repository
R293 Baloo
Branch
more-excluded-files (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 11703
Build 11721: arc lint + arc unit
ngraham created this revision.May 3 2019, 2:42 AM
Restricted Application added projects: Frameworks, Baloo. · View Herald TranscriptMay 3 2019, 2:42 AM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
ngraham requested review of this revision.May 3 2019, 2:42 AM
ngraham updated this revision to Diff 57460.May 3 2019, 1:29 PM

Add more useless Virtualbox files that Baloo shouldn't try to index

ngraham edited the test plan for this revision. (Show Details)May 3 2019, 1:30 PM
pino added a subscriber: pino.May 9 2019, 6:20 PM

While you are there adding filters, what about:

  • *.qcow2 -- QCOW2 disk images for QEMU
  • *.raw/*.img -- typical extensions for raw disk images (there is no fixed extension, as a raw disk image is just a file with bit-by-bit representation of the disk of a VM)
  • *.vmdk -- VMware disk images
  • *.vhd/*.vhdx -- Hyper-V disk images
ngraham updated this revision to Diff 57824.May 9 2019, 9:52 PM

Exclude more VM-related files

ngraham retitled this revision from Exclude .gcode and .vdi files from indexing consideration to Exclude .gcode and virtual machine files from indexing consideration.May 9 2019, 9:53 PM
ngraham edited the summary of this revision. (Show Details)
This revision was not accepted when it landed; it landed in state Needs Review.May 14 2019, 3:33 PM
Closed by commit R293:7f9ecb88253c: Exclude .gcode and virtual machine files from indexing consideration (authored by ngraham). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/file/fileexcludefilters.cpp (11 lines)

Diff 57824

View Options

src/file/fileexcludefilters.cpp

Loading...