Differential D20962

Fix opening the New Mail Notifier agent configuration
ClosedPublic
Actions

Authored by dvratil on May 2 2019, 2:17 PM.

Details

Reviewers
mlaurent
vkrause
Commits
R206:3043f4484f77: Fix opening the New Mail Notifier agent configuration
Summary

This got accidentally broken by removing the showConfigurationDialog() method
from the resource's DBus interface. Instead of relying on DBus, use the new
in-process configuration dialog tooling.

Test Plan

Clicking 'Other Actions' button in KMail's receiving account configuration
tab works again

Diff Detail

Repository
R206 KMail
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
dvratil created this revision.May 2 2019, 2:17 PM
Restricted Application added a project: KDE PIM. · View Herald TranscriptMay 2 2019, 2:17 PM
Restricted Application added a subscriber: kde-pim. · View Herald Transcript
dvratil requested review of this revision.May 2 2019, 2:17 PM
dvratil updated this revision to Diff 57382.May 2 2019, 2:19 PM

Use const

vkrause accepted this revision.May 3 2019, 7:21 AM
This revision is now accepted and ready to land.May 3 2019, 7:21 AM
Closed by commit R206:3043f4484f77: Fix opening the New Mail Notifier agent configuration (authored by dvratil). · Explain WhyMay 3 2019, 9:23 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 57448

View Options

src/configuredialog/configureaccountpage.cpp

Loading...