Differential D20957

Fix build with libvlc 2.2
ClosedPublic
Actions

Authored by wbauer on May 2 2019, 10:39 AM.

Details

Reviewers
mauroc
Summary

libvlc_RendererDiscovererItemAdded and libvlc_RendererDiscovererItemDeleted apparently only exist since 3.0, leading to not declared in this scope compiler errors when building with earlier versions.

BUG: 407153

Test Plan

Builds fine now with libvlc 2.2.6.

Diff Detail

Repository
R466 Kaffeine
Lint
Lint Skipped
Unit
Unit Tests Skipped
wbauer requested review of this revision.May 2 2019, 10:39 AM
wbauer updated this revision to Diff 57371.
wbauer created this revision.

Updated diff to include full context.

mauroc accepted this revision.May 2 2019, 11:34 AM

Patch makes sense to me.

This revision is now accepted and ready to land.May 2 2019, 11:34 AM
wbauer added a comment.May 2 2019, 12:14 PM

As mentioned in the bugreport, I noticed meanwhile that playback doesn't seem to work at all with libvlc 2.2.6.

Should I still commit this change?

mauroc added a comment.May 2 2019, 1:19 PM

Yeah, I saw your comment there... yeah, I guess you should go ahead and merge it. It won't hurt.

I'm finishing a meeting right now... need to think a little bit about dropping support for vlc 2.x. That probably makes sense anyway, as lots of operators are now using video formats not supported by vlc 2.x, but please give me some time to take a look on it.

wbauer closed this revision.May 3 2019, 6:57 PM

The change is part of 402cbee5e675.

Revision Contents
Changeset List

PathPackages
Msrc/backend-vlc/vlcmediawidget.cpp (2 lines)

Diff 57370

View Options

src/backend-vlc/vlcmediawidget.cpp

Loading...