[baloo_file] Wait for extractor process to start
ClosedPublic

Authored by nicolasfella on May 1 2019, 3:54 PM.

Details

Summary

When running baloo_file I hit the assert in extractorprocess.cpp:63. This was because the extractor process was not yet running when index was called. This could be observerd by connecting to the QProcess::started signal. Let's wait for the process to start before doing the indexing

Test Plan

Before: run baloo_file -> assert
After: run baloo_file -> no assert, balooctl monitor shows that files are indexed

Diff Detail

Repository
R293 Baloo
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
nicolasfella created this revision.May 1 2019, 3:54 PM
Restricted Application added projects: Frameworks, Baloo. · View Herald TranscriptMay 1 2019, 3:54 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
nicolasfella requested review of this revision.May 1 2019, 3:54 PM
apol added a subscriber: apol.May 1 2019, 3:58 PM
apol added inline comments.
src/file/extractorprocess.cpp
47

Maybe this should be called in ::index then? This way we only block where it breaks.

bruns requested changes to this revision.May 2 2019, 2:42 AM
bruns added a subscriber: bruns.
bruns added inline comments.
src/file/extractorprocess.cpp
62–63

This assert is just nonsense ...

This revision now requires changes to proceed.May 2 2019, 2:42 AM
  • Remove assert
bruns accepted this revision.May 2 2019, 10:18 AM
This revision is now accepted and ready to land.May 2 2019, 10:18 AM
This revision was automatically updated to reflect the committed changes.
bruns added a comment.May 2 2019, 10:31 AM

You better had fixed the commit message ...