With increasing number of flags and also bug tags in cpuinfo (sepctre, meltdown, …) the size increases and with 32 cores it´s to smal.
Increasing size of cpuinfo buffer to 1,5 kiB and 64 cores.
BUG: 384515
With increasing number of flags and also bug tags in cpuinfo (sepctre, meltdown, …) the size increases and with 32 cores it´s to smal.
Increasing size of cpuinfo buffer to 1,5 kiB and 64 cores.
BUG: 384515
Test with 32 cores and on and see that applet is working again
Lint Skipped |
Unit Tests Skipped |
I don't think that 1024 represents anything here, just the factor to get kibibytes.
So just bump the first value to 64, or even 128.
What's the size of /proc/cpuinfo on your system?
The info for each CPU is indeed a bit larger than 1K. Using 64KiB will only be sufficient for 32 CPUs, the rest would be wasted. As the comment in the bug ticket indicates, Linux supports up to 4096 CPUs, so the buffer should be much bigger, or (ideally) the code refactored to do incremental parsing of the /proc/cpuinfo content.
And indeed I didn't mark the bug as a junior job, because incremental parsing the info isn't exactly a quick fix.