- Port to QQC2+Kirigami FormLayout
- Improve some strings
- Follow the KDE HIG
- Improve look of controls
Details
Details
- Reviewers
ngraham - Group Reviewers
Plasma VDG - Maniphest Tasks
- T10586: Modernize widget configuration settings
- Commits
- R119:9dcc29663bd7: [kimpanel] Port settings page to QQC2+Kirigami FormLayout and modernize UI
Open the Input Method Panel widget settings.
Diff Detail
Diff Detail
- Repository
- R119 Plasma Desktop
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Comment Actions
FWIW the Pager widget uses radio buttons for its vertical/horizontal chooser UI. We might want to consider doing the same thing here too. I think it's a nicer UI than having using a checkbox, as it makes the opposite state 100% explicit.
| applets/kimpanel/package/contents/ui/ConfigAppearance.qml | ||
|---|---|---|
| 44 | A list of what? Maybe make it explicit in the label. | |
| 62 | Is this necessary? I thought true was the default for this. | |
| 63 | This should be translated with i18nc() (the correct order of elements may be different in other languages) | |
| applets/kimpanel/package/contents/config/main.xml | ||
|---|---|---|
| 13 ↗ | (On Diff #57216) | If you change the name of any properties in the config xml file, users who have altered the settings will unexpectedly get new values and yell at you (well, whoever triages bugs, i.e. me and Christoph). :) If you do this, you need to provide a kconf update script that adjusts people's settings. See https://techbase.kde.org/Development/Tools/Using_kconf_update Alternatively, you can keep the existing config name and just change the logic in the UI so that it still reads and writes the data in the same way, it's just presented to the user differently. |