[kimpanel] Port settings page to QQC2+Kirigami FormLayout and modernize UI

Authored by GB_2 on Apr 29 2019, 7:20 PM.


  • Port to QQC2+Kirigami FormLayout
  • Improve some strings
  • Follow the KDE HIG
  • Improve look of controls

Test Plan

Open the Input Method Panel widget settings.

Diff Detail

R119 Plasma Desktop
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.
GB_2 created this revision.Apr 29 2019, 7:20 PM
Restricted Application added a project: Plasma. · View Herald TranscriptApr 29 2019, 7:20 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
GB_2 requested review of this revision.Apr 29 2019, 7:20 PM

FWIW the Pager widget uses radio buttons for its vertical/horizontal chooser UI. We might want to consider doing the same thing here too. I think it's a nicer UI than having using a checkbox, as it makes the opposite state 100% explicit.


A list of what? Maybe make it explicit in the label.


Is this necessary? I thought true was the default for this.


This should be translated with i18nc() (the correct order of elements may be different in other languages)

GB_2 updated this revision to Diff 57216.Apr 29 2019, 8:51 PM
GB_2 marked 3 inline comments as done.

Address comments

ngraham requested changes to this revision.Apr 29 2019, 9:05 PM
ngraham added inline comments.
13 ↗(On Diff #57216)

If you change the name of any properties in the config xml file, users who have altered the settings will unexpectedly get new values and yell at you (well, whoever triages bugs, i.e. me and Christoph). :)

If you do this, you need to provide a kconf update script that adjusts people's settings. See https://techbase.kde.org/Development/Tools/Using_kconf_update

Alternatively, you can keep the existing config name and just change the logic in the UI so that it still reads and writes the data in the same way, it's just presented to the user differently.

This revision now requires changes to proceed.Apr 29 2019, 9:05 PM
GB_2 updated this revision to Diff 57274.Apr 30 2019, 3:24 PM

Invert checkbox in UI logic instead, fix font preview

ngraham accepted this revision.Apr 30 2019, 5:57 PM
This revision is now accepted and ready to land.Apr 30 2019, 5:57 PM
This revision was automatically updated to reflect the committed changes.