Differential D20905

[Timer] Port settings window to QQC2+Kirigami FormLayout and modernize UI
ClosedPublic
Actions

Authored by ngraham on Apr 29 2019, 6:20 PM.

Details

Reviewers
davidedmundson
filipf
Group Reviewers
VDG
Plasma
Maniphest Tasks
T10586: Modernize widget configuration settings
Commits
R114:ad66b200036e: [Timer] Port settings window to QQC2+Kirigami FormLayout and modernize UI
Summary
  • Port to QQC2+Kirigami FormLayout style
  • Use standard import names
  • Adjust some strings to sound a bit more natural
Test Plan



Everything works.

Diff Detail

Repository
R114 Plasma Addons
Branch
timer-modernize-settings-window (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 11361
Build 11379: arc lint + arc unit
ngraham created this revision.Apr 29 2019, 6:20 PM
Restricted Application added a project: Plasma. · View Herald TranscriptApr 29 2019, 6:20 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
ngraham requested review of this revision.Apr 29 2019, 6:20 PM
ngraham updated this revision to Diff 57215.Apr 29 2019, 8:30 PM

Whoops, I forgot the Advanced page. Also do that!

ngraham edited the test plan for this revision. (Show Details)Apr 29 2019, 8:30 PM
davidedmundson accepted this revision.Apr 29 2019, 10:57 PM
This revision is now accepted and ready to land.Apr 29 2019, 10:57 PM
filipf accepted this revision.Apr 30 2019, 1:29 AM
Closed by commit R114:ad66b200036e: [Timer] Port settings window to QQC2+Kirigami FormLayout and modernize UI (authored by ngraham). · Explain WhyApr 30 2019, 4:00 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 57215

View Options

applets/timer/package/contents/ui/configAdvanced.qml

Loading...
View Options

applets/timer/package/contents/ui/configAppearance.qml

Loading...