[User Switcher] Port settings window to QQC2+Kirigami FormLayout and modernize UI
ClosedPublic

Authored by ngraham on Apr 29 2019, 2:29 PM.

Details

Summary
  • Port to QQC2+Kirigami FormLayout style
  • Adjust some strings to sound a bit more natural
Test Plan

Everything was tested and still works.

Diff Detail

Repository
R114 Plasma Addons
Branch
user-switcher-modernize-settings-window (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 11348
Build 11366: arc lint + arc unit
ngraham created this revision.Apr 29 2019, 2:29 PM
Restricted Application added a project: Plasma. · View Herald TranscriptApr 29 2019, 2:29 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
ngraham requested review of this revision.Apr 29 2019, 2:29 PM
filipf added a subscriber: filipf.Apr 29 2019, 2:46 PM
filipf added inline comments.
applets/userswitcher/package/contents/ui/configGeneral.qml
86

Maybe we could say "User picture" just to be more precise?

100

Ditto.

117

Not related to your changes, but can you help me out lol, what does this option do? I'm not seeing anything happening when I turn it on or off.

broulik added inline comments.
applets/userswitcher/package/contents/ui/configGeneral.qml
46

Shouldn't that be onClicked to only trigger on explicit user interaction?

ngraham updated this revision to Diff 57190.Apr 29 2019, 2:58 PM
ngraham marked 3 inline comments as done.

Address review comments

ngraham edited the test plan for this revision. (Show Details)Apr 29 2019, 2:58 PM
ngraham updated this revision to Diff 57194.Apr 29 2019, 3:19 PM

Tweak a string

ngraham edited the test plan for this revision. (Show Details)Apr 29 2019, 3:19 PM
filipf accepted this revision.Apr 29 2019, 3:20 PM
This revision is now accepted and ready to land.Apr 29 2019, 3:20 PM
broulik accepted this revision.Apr 29 2019, 3:22 PM
This revision was automatically updated to reflect the committed changes.