| aacid |
| Okular |
On high res displays we end up using
the tile manager on single pages, that doesn't work
(for reasons that aren't yet clear) - but it
doesn't make sense if we need the whole thing anyway.
Pass the normalizedRectangle to show we need the whole
page (which fixes *some* of the issues by itself),
and then don't bother using tileManager if we're
using most of the page anyway.
BUG: 401339
| Automatic diff as part of commit; lint not applicable. |
| Automatic diff as part of commit; unit tests not applicable. |
I understand the qDebugs where useful for you, but i will remove them, okular is already quite noisy in debug mode.
The fix makes sense, no need to trigger the tiled rendering if you're going to end up rendering the whole page anyway, on the other hand the hardcoded 8M and 6M should probabbly removed at some point too.
I'm going to commit it without the debugs and without the change in presentationwidget since i'm 99% sure the check for 0 you added there is enough
Please shout if you disagree, sorry it took this much to review.
| core/document.cpp | ||
|---|---|---|
| 1306 | make this const | |
| ui/presentationwidget.cpp | ||
| 1450 ↗ | (On Diff #57142) | why this change? You already "fixed" this with the check for normalized area not being 0, no? |