Differential D20843

Fix CMakeLists always building examples.
ClosedPublic
Actions

Authored by barchiesi on Apr 26 2019, 1:22 PM.

Details

Reviewers
dvratil
Commits
R477:2fc71a173504: Fix CMakeLists always building examples.
Summary

The README.md states that KGAPI_BUILD_EXAMPLES can be used to build examples, however examples are build regardless of the variables value. This patch fixes this behavior and adds an explanation for the BUILD_TESTING variable.

Diff Detail

Repository
R477 KGAPI Library
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
barchiesi created this revision.Apr 26 2019, 1:22 PM
Restricted Application added a project: KDE PIM. · View Herald TranscriptApr 26 2019, 1:22 PM
Restricted Application added a subscriber: kde-pim. · View Herald Transcript
barchiesi requested review of this revision.Apr 26 2019, 1:22 PM
dvratil accepted this revision.Apr 28 2019, 3:11 PM
This revision is now accepted and ready to land.Apr 28 2019, 3:11 PM
barchiesi updated this revision to Diff 58519.May 22 2019, 10:50 PM

Changed (wrong) commit email address.

dvratil accepted this revision.May 23 2019, 8:30 AM

Sorry, I must have overlooked this one :( You should be able to commit it for yourself now (arc land).

Closed by commit R477:2fc71a173504: Fix CMakeLists always building examples. (authored by barchiesi). · Explain WhyMay 23 2019, 8:39 AM
This revision was automatically updated to reflect the committed changes.
barchiesi added a comment.May 23 2019, 8:41 AM
In D20843#468955, @dvratil wrote:

Sorry, I must have overlooked this one :( You should be able to commit it for yourself now (arc land).

Yes!

Revision Contents
Changeset List

PathPackages
MCMakeLists.txt (4 lines)
MREADME.md (2 lines)

Diff 58536

View Options

CMakeLists.txt

Loading...
View Options

README.md

Loading...