Differential D20842

Colors Histogram Channel in Editor-Curves tool
Needs RevisionPublic
Actions

Authored by dsam82 on Apr 26 2019, 1:07 PM.

Details

Reviewers
cgilles
mqualmann
Group Reviewers
Digikam
Test Plan

LRGBAC channels are all given in a combobox in editor-curves tool.
User will select the colors channel and can see the changes in all channels simultaneously.

Diff Detail

Repository
R482 digiKam
Lint
Lint Skipped
Unit
Unit Tests Skipped
dsam82 requested review of this revision.Apr 26 2019, 1:07 PM
dsam82 created this revision.
mqualmann requested changes to this revision.Apr 26 2019, 9:05 PM

Patch works but we still have to polish something.
Please use if (... not if(...
NUM_CHANNELS == 5, look again at line 1158 of imagecurves.cpp

Maik

This revision now requires changes to proceed.Apr 26 2019, 9:05 PM
dsam82 added a comment.EditedMay 2 2019, 9:13 PM

digiKam is crashing when Colors channel is selected and we change the curve type.
I have tried other methods also like (channel < ColorChannels) in setCurveType function but it doesn't work.
What is the issue?

Sambhav

Revision Contents
Changeset List

Diff 57034

View Options

core/dplugins/editor/colors/adjustcurves/adjustcurvestool.cpp

Loading...
View Options

core/libs/dimg/filters/curves/curveswidget.cpp

Loading...
View Options

core/libs/dimg/filters/curves/imagecurves.cpp

Loading...