Differential D20841

Extract HideRectItem class
ClosedPublic
Actions

Authored by volkov on Apr 26 2019, 12:47 PM.

Details

Reviewers
sars
Commits
R382:9690fd2162dd: Extract HideRectItem class

Diff Detail

Repository
R382 KSane Library
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
volkov requested review of this revision.Apr 26 2019, 12:47 PM
volkov created this revision.
volkov added a reviewer: sars.Apr 26 2019, 9:36 PM
sars accepted this revision.Apr 28 2019, 6:36 PM

Please fix the copyright owner and date of the files before committing.

This revision is now accepted and ready to land.Apr 28 2019, 6:36 PM
volkov updated this revision to Diff 57166.Apr 29 2019, 10:20 AM

fix copyrights

sars added a comment.Apr 29 2019, 12:10 PM

My name does not need to be in there since I have not touched that file yet ;)

volkov added a comment.Apr 29 2019, 12:12 PM

But the code is yours, isn't it?

sars added a comment.Apr 29 2019, 12:21 PM

That particular class is yours :)

I started the project over 10 years ago, but since it is a KDE project and I have gotten a LOT of help, I cannot require everybody to give me the copyright when they contribute. When you contribute, that contribution is yours and we all benefit :)

volkov updated this revision to Diff 57177.Apr 29 2019, 12:26 PM

ok, leave only my own copyright

sars accepted this revision.Apr 29 2019, 12:33 PM
Closed by commit R382:9690fd2162dd: Extract HideRectItem class (authored by volkov). · Explain WhyApr 29 2019, 1:09 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/CMakeLists.txt (1 line)
AMsrc/hiderectitem.h (43 lines)
AMsrc/hiderectitem.cpp (41 lines)
Msrc/ksaneviewer.cpp (37 lines)

Diff 57179

View Options

src/CMakeLists.txt

Loading...
View Options

src/hiderectitem.h

Loading...
View Options

src/hiderectitem.cpp

Loading...
View Options

src/ksaneviewer.cpp

Loading...