Differential D20826

Allow building without a CMAKE_BUILD_TYPE
ClosedPublic
Actions

Authored by apol on Apr 25 2019, 6:51 PM.

Details

Reviewers
sirgienko
Group Reviewers
Cantor
Commits
R55:b428f04ce948: Allow building without a CMAKE_BUILD_TYPE
Summary

CMake Error at CMakeLists.txt:83 (string):

string no output variable specified

Diff Detail

Repository
R55 Cantor
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
apol created this revision.Apr 25 2019, 6:51 PM
Restricted Application added a project: KDE Edu. · View Herald TranscriptApr 25 2019, 6:51 PM
Restricted Application added a subscriber: kde-edu. · View Herald Transcript
apol requested review of this revision.Apr 25 2019, 6:51 PM
apol edited reviewers, added: Cantor; removed: Kdenlive.Apr 25 2019, 6:51 PM
sirgienko added a subscriber: sirgienko.Apr 25 2019, 7:01 PM

We could allows it, but could you bring an example, when you don't use CMAKE_BUILD_TYPE please?

apol added a comment.Apr 25 2019, 7:17 PM

We were not explicitly setting it in the flatpak nightly builds and it was failing because of that. We are now so it's not an issue anymore there.

An alternative would be an if (NOT CMAKE_BUILD_TYPE) return(), because otherwise the error message is quite confusing.

sirgienko added a comment.Apr 25 2019, 7:22 PM

Actually, the only reason, that we use CMAKE_BUILD_TYPE, is QT_NO_DEBUG_OUTPUT. Cantor disables qDebug for release build, for performence and user-expirience reasons.

sirgienko added a comment.Apr 25 2019, 7:24 PM

I could add code for handle a situation, when CMAKE_BUILD_TYPE don't set, with disable qt output, is it enought good for you?

apol added a comment.Apr 25 2019, 11:37 PM
In D20826#456275, @sirgienko wrote:

I could add code for handle a situation, when CMAKE_BUILD_TYPE don't set, with disable qt output, is it enought good for you?

that's what this patch does too, right?

sirgienko accepted this revision.Apr 26 2019, 3:40 PM
This revision is now accepted and ready to land.Apr 26 2019, 3:40 PM
Closed by commit R55:b428f04ce948: Allow building without a CMAKE_BUILD_TYPE (authored by apol). · Explain WhyApr 26 2019, 11:15 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
MCMakeLists.txt (2 lines)

Diff 57076

View Options

CMakeLists.txt

Loading...