CMake Error at CMakeLists.txt:83 (string):
string no output variable specified
sirgienko |
Cantor |
CMake Error at CMakeLists.txt:83 (string):
string no output variable specified
Automatic diff as part of commit; lint not applicable. |
Automatic diff as part of commit; unit tests not applicable. |
We could allows it, but could you bring an example, when you don't use CMAKE_BUILD_TYPE please?
We were not explicitly setting it in the flatpak nightly builds and it was failing because of that. We are now so it's not an issue anymore there.
An alternative would be an if (NOT CMAKE_BUILD_TYPE) return(), because otherwise the error message is quite confusing.
Actually, the only reason, that we use CMAKE_BUILD_TYPE, is QT_NO_DEBUG_OUTPUT. Cantor disables qDebug for release build, for performence and user-expirience reasons.
I could add code for handle a situation, when CMAKE_BUILD_TYPE don't set, with disable qt output, is it enought good for you?