Differential D20810

Fix launcher URL comparison
ClosedPublic
Actions

Authored by broulik on Apr 25 2019, 1:19 PM.

Details

Reviewers
hein
ngraham
mlaurent
apol
Group Reviewers
Plasma
Commits
R119:b6b008bbf0ec: Fix launcher URL comparison
Summary

Launcher URL is a QUrl which doesn't strictly map empty string.

Test Plan

Pin to task bar and start new instance is correctly disabled now if no launcher url could be determined
Yet another regression caused by 6e36de2e1e92743751ddd5b735cdfe9b2e95e5e2

Diff Detail

Repository
R119 Plasma Desktop
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik created this revision.Apr 25 2019, 1:19 PM
Restricted Application added a project: Plasma. · View Herald TranscriptApr 25 2019, 1:19 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
broulik requested review of this revision.Apr 25 2019, 1:19 PM
ngraham edited the summary of this revision. (Show Details)Apr 25 2019, 1:20 PM
ngraham edited the summary of this revision. (Show Details)Apr 25 2019, 1:27 PM
apol accepted this revision.Apr 25 2019, 4:07 PM
apol added a subscriber: apol.
apol added inline comments.
applets/taskmanager/package/contents/ui/ContextMenu.qml
279

how about enabled: visualParent && get(atm.LauncherUrlWithoutIcon)?

This revision is now accepted and ready to land.Apr 25 2019, 4:07 PM
ngraham accepted this revision.Apr 25 2019, 4:08 PM
Closed by commit R119:b6b008bbf0ec: Fix launcher URL comparison (authored by broulik). · Explain WhyApr 26 2019, 10:05 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 57017

View Options

applets/taskmanager/package/contents/ui/ContextMenu.qml

Loading...